Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove extra fields in create table statements #6677

Merged
merged 2 commits into from
Dec 17, 2024
Merged

Remove extra fields in create table statements #6677

merged 2 commits into from
Dec 17, 2024

Conversation

bethanyhipple-dbtlabs
Copy link
Contributor

@bethanyhipple-dbtlabs bethanyhipple-dbtlabs commented Dec 16, 2024 •
edited by github-actions bot
Loading

What are you changing in this pull request and why?

The CSV files for orders and payment don't have _etl_loaded_at and batched_at respectively. So removing these fields from the create table statements.

Checklist

  • [X ] I have reviewed the Content style guide so my content adheres to these guidelines.
  • The topic I'm writing about is for specific dbt version(s) and I have versioned it according to the version a whole page and/or version a block of content guidelines.
  • I have added checklist item(s) to this list for anything anything that needs to happen before this PR is merged, such as "needs technical review" or "change base branch."
  • The content in this PR requires a dbt release note, so I added one to the release notes page.

🚀 Deployment available! Here are the direct links to the updated files:

@bethanyhipple-dbtlabs
Remove extra fields in create table statements
a7e7e1b 
The CSV files for orders and payment don't have _etl_loaded_at and batched_at respectively. So removing these fields from the create table statements.
@bethanyhipple-dbtlabs bethanyhipple-dbtlabs requested a review from a team as a code owner December 16, 2024 22:59
@vercel Vercel
Copy link

vercel bot commented Dec 16, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs-getdbt-com ✅ Ready (Inspect) Visit Preview Dec 17, 2024 10:29am

@github-actions github-actions bot added content Improvements or additions to content guides Knowledge best suited for Guides size: x-small This change will take under 3 hours to fix. labels Dec 16, 2024
mirnawong1
mirnawong1 approved these changes Dec 17, 2024
View reviewed changes
Copy link
Contributor

@mirnawong1 mirnawong1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for opening this up @bethanyhipple-dbtlabs ! approved and merging for you!

@mirnawong1
Copy link
Contributor

hey @bethanyhipple-dbtlabs , would this be the same for the snowflake quickstart: https://docs.getdbt.com/guides/snowflake?step=3
Screenshot 2024-12-17 at 10 28 42

@mirnawong1 mirnawong1 enabled auto-merge December 17, 2024 10:29
@mirnawong1 mirnawong1 merged commit 79ac1b3 into current Dec 17, 2024
8 checks passed
@mirnawong1 mirnawong1 deleted the bethanyhipple-dbtlabs-patch-1 branch December 17, 2024 10:29
@bethanyhipple-dbtlabs
Copy link
Contributor Author

@mirnawong1 This is not the same for the Snowflake Quickstart. The CSV file in the Redshift guide is a slightly different data set than the one the Snowflake guide uses in the S3 bucket. I'm not sure why they are different though 🤷‍♀️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mirnawong1 mirnawong1 mirnawong1 approved these changes

Assignees
No one assigned
Labels
content Improvements or additions to content guides Knowledge best suited for Guides size: x-small This change will take under 3 hours to fix.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bethanyhipple-dbtlabs @mirnawong1